MEPX
Chapter 10 of 10All chapters

Chapter 10 of 10

Reading in review

A different goal.

What review is for

A reviewer checks that the change does what it claims, handles the edges, and can be understood in six months. It is not a search for style violations a formatter should catch.

  • Ask questions rather than issuing instructions; you may be missing context.
  • Small changes get real review. Large ones get approval.

Reading your own code

Reread your change as a stranger before sending it. Most of the comments you would have received are visible from that angle.